Skip to content

Commit

Permalink
fix: mark transactions as failed for cancelled / unknown smart transa… (
Browse files Browse the repository at this point in the history
#12820)

…ctions (#12664)

Resolves an issue with stuck transactions for some users who used smart
transactions, which was caused by having [this
PR](#12274) in the
7.36.0 release even when it was marked for 7.37.0 by metamaskbot.

Fixes:

1. Cancelled transaction stuck thanks to super low gas settings
2. All other submitted transactions afterwards as well with the
invalid_nonce error.
3. Upgrade to 7.37.1 and see all cancelled tx
4. Try a new tx

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

https://consensys.slack.com/archives/C084S32G337/p1734034013370979

https://consensys.slack.com/archives/C084S32G337/p1734039388196979

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Daniel <[email protected]>
  • Loading branch information
smilingkylan and dan437 authored Dec 20, 2024
1 parent 25fbf35 commit 029c49c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions app/store/migrations/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ import migration59 from './059';
import migration60 from './060';
import migration61 from './061';
import migration62 from './062';
import migration63 from './063';

type MigrationFunction = (state: unknown) => unknown;
type AsyncMigrationFunction = (state: unknown) => Promise<unknown>;
Expand Down Expand Up @@ -138,6 +139,7 @@ export const migrationList: MigrationsList = {
60: migration60,
61: migration61,
62: migration62,
63: migration63,
};

// Enable both synchronous and asynchronous migrations
Expand Down

0 comments on commit 029c49c

Please sign in to comment.