fix: prevent non-current network tokens from being hidden incorrectly

[salimtb]

Description

fix to prevent non current network tokens from being hidden incorrecly

core PR: MetaMask/core#4967

Related issues

Fixes:

Manual testing steps

1. add different network accros different chains
2. choose ethereum as current chain
3. try to hide token of polygon for instance

Screenshots/Recordings

Before

bug.mov

After

fixed.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [9787615]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1862 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	345	2391	1802	381	183
		domContentLoaded	1650	2251	1832	164	79
		load	1671	2377	1862	179	86
		domInteractive	21	154	40	29	14
		backgroundConnect	10	113	32	24	11
		firstReactRender	56	133	100	20	10
		getState	5	79	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1174	1666	1337	135	65
		setupStore	6	60	19	20	9
		uiStartup	1855	2743	2068	216	104

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 181 Bytes (0.00%)

[gambinish]

Pulled down and ran, LGTM.

I'll hit you up on Slack with a non-blocking question.

[metamaskbot]

Builds ready [a45a34a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1669 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1428	2114	1673	187	90
		domContentLoaded	1408	2061	1627	175	84
		load	1430	2142	1669	193	93
		domInteractive	24	64	36	13	6
		backgroundConnect	14	102	43	24	11
		firstReactRender	16	99	44	27	13
		getState	5	78	19	21	10
		initialActions	0	1	0	0	0
		loadScripts	1028	1492	1194	143	69
		setupStore	6	83	17	23	11
		uiStartup	1584	2585	1938	254	122

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 181 Bytes (0.00%)

[Unik0rnMaggie]

Not present in qa-8 build

Hide.token.mov