Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing filter for scheduled job rerun-from-failed #28644

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Nov 22, 2024

Description

After the rerun from failed PR was merged there was one remaining filter to tweak, related to the scheduled trigger that will be done in the UI:

  • In the Circle ci UI panel, there is no way to tell to trigger a specific workflow, rather all the config file will be checked, which means both the test_and_release and the rerun_from_failed workflows would run. For that, we need to add a filter in the test_and_release flow, so that is not run when we schedule the automatic runs using the name rerun-from-failed. Unfortunately there is no way to do this from the UI, so we need this filter in the config file

  • I saw, that the rerun-failed workflow was run once the PR was merged, which shouldn't be the case. I've tweaked that following this example in circle ci docs)

Screenshot from 2024-11-22 11-06-07

Why this was missed: on the testing for the previous PR, I removed ALL the filters, to make the rerun-from-failed workflow run and check that it works (it worked). However, I didn't test leaving the filter of the [rerun-from-failed, << pipeline.schedule.name >>] and checking that it is not run

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

How to test this: instead of removing ALL the filters (like it was done for testing the previous PR), just remove the filter for develop. This way, we can see if the job rerun-from-failed is run --> it shouldn't be, as it's not a scheduled run with that name.

It can be checked here: see only the test and release is run

Screenshot from 2024-11-22 11-12-15

For testing the scheduled run, it needs to be done in the UI once this PR is merged, but if the filter has been proven to work here, it should then also work there, for when it needs to be run

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -358,14 +360,10 @@ workflows:

rerun-from-failed:
when:
condition:
equal: ["<< pipeline.schedule.name >>", "rerun-from-failed"]
equal: [rerun-from-failed, << pipeline.schedule.name >>]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seaona seaona changed the title chore: missing filter fix: add missing filter for scheduled job rerun-from-failed Nov 22, 2024
@seaona seaona self-assigned this Nov 22, 2024
@seaona seaona marked this pull request as ready for review November 22, 2024 10:19
@seaona seaona requested review from kumavis and a team as code owners November 22, 2024 10:19
@seaona seaona added the area-qa Relating to QA work (Quality Assurance) label Nov 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [85ef298]
Page Load Metrics (1781 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30023541718356171
domContentLoaded16152255174813264
load16582355178114670
domInteractive248042189
backgroundConnect11102342412
firstReactRender823841548742
getState588172210
initialActions01000
loadScripts1158155512869043
setupStore648994
uiStartup186028662066236113
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona seaona added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 592a628 Nov 25, 2024
113 checks passed
@seaona seaona deleted the rerun-failed-missing-filter branch November 25, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants