Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change description of enabling simulation message in settings #28536

Merged
merged 44 commits into from
Nov 25, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 19, 2024

Description

Change description of setting top enable simulation to include signatures.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3642

Manual testing steps

  1. Go to settings page
  2. Check setting to enable simulation

Screenshots/Recordings

Screenshot 2024-11-19 at 3 39 22 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri and others added 30 commits November 7, 2024 14:56
@jpuri jpuri added the team-confirmations Push issues to confirmations team label Nov 19, 2024
@jpuri jpuri requested a review from a team as a code owner November 19, 2024 10:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [5829b1a]
Page Load Metrics (1870 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16702163187014369
domContentLoaded16572134183813163
load16672154187014268
domInteractive297741157
backgroundConnect9114352512
firstReactRender542971346732
getState590272813
initialActions01000
loadScripts11681627134411254
setupStore511721
uiStartup18702563216218589
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -106.79 KiB (-1.76%)
  • ui: 8.64 KiB (0.11%)
  • common: 107.3 KiB (1.30%)

matthewwalsh0
matthewwalsh0 previously approved these changes Nov 22, 2024
Base automatically changed from state_change_tooltips to develop November 25, 2024 11:35
@jpuri jpuri dismissed matthewwalsh0’s stale review November 25, 2024 11:35

The base branch was changed.

@danjm danjm requested a review from a team as a code owner November 25, 2024 11:35
@metamaskbot
Copy link
Collaborator

Builds ready [0bb74b9]
Page Load Metrics (2156 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32223121778679326
domContentLoaded18462505213018388
load18592522215617986
domInteractive28133472411
backgroundConnect1077322311
firstReactRender833821425828
getState777302512
initialActions01000
loadScripts13261891156715373
setupStore66317178
uiStartup21372793244118488
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -4 Bytes (-0.00%)

@jpuri jpuri enabled auto-merge November 25, 2024 12:50
@jpuri jpuri added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@jpuri jpuri added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@jpuri jpuri added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit b148c25 Nov 25, 2024
75 checks passed
@jpuri jpuri deleted the simulation_message_change branch November 25, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants