Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json-rpc-middleware-stream@^5 -> @metamask/json-rpc-middleware-stream@^8 #28060

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 24, 2024

Description

  • Replace legacy json-rpc-middleware-stream@^5 (2023-09-27) with @metamask/json-rpc-middleware-stream@^8 (2024-10-16)

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +1 220 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@legobeat legobeat changed the title deps: json-rpc-middleware-stream@^5 -> @metamask/json-rpc-middleware-stream@^8 fix(deps) json-rpc-middleware-stream@^5 -> @metamask/json-rpc-middleware-stream@^8 Oct 24, 2024
@legobeat legobeat changed the title fix(deps) json-rpc-middleware-stream@^5 -> @metamask/json-rpc-middleware-stream@^8 fix: json-rpc-middleware-stream@^5 -> @metamask/json-rpc-middleware-stream@^8 Oct 24, 2024
@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 24, 2024
@legobeat legobeat marked this pull request as ready for review October 24, 2024 05:50
@legobeat legobeat requested review from a team as code owners October 24, 2024 05:50
@legobeat legobeat force-pushed the deps-json-rpc-middleware-stream branch 2 times, most recently from cd9901c to 968fe44 Compare October 24, 2024 10:07
@legobeat legobeat force-pushed the deps-json-rpc-middleware-stream branch from 968fe44 to ad3acdc Compare October 25, 2024 01:21
@hjetpoluru hjetpoluru self-requested a review October 25, 2024 17:06
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjetpoluru hjetpoluru added this pull request to the merge queue Oct 25, 2024
Merged via the queue into MetaMask:develop with commit c4727d9 Oct 25, 2024
76 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
@legobeat legobeat deleted the deps-json-rpc-middleware-stream branch October 25, 2024 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants