Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate-AvatarIcon #19023

Closed
wants to merge 53 commits into from
Closed

Conversation

thebinij
Copy link
Contributor

@thebinij thebinij commented May 5, 2023

Explanation

Closes #18883

Manual Testing Steps

No functional changes

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@thebinij thebinij requested a review from a team as a code owner May 5, 2023 10:59
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 8, 2023
@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for matthewwalsh0 May 10, 2023 00:49
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the comments in the other PRs relate to this one so I will do a full review after the others have been addressed

yarn.lock Outdated
checksum: bc8ab55cd194e240152946b54bfaff7456180cc018674fc7ed134f4f502192405f6643f422feaa0a5e7cc02b5bac564cfac7771ac6d29f5d129482fcfe335ba1
version: 1.0.30001482
resolution: "caniuse-lite@npm:1.0.30001482"
checksum: a5f7681c860a29736f29350ebd81041c40b6aa7b2f94c50ed27284a0507e46dc79536dcfc05432504cfc80a0bf2070e4ad6fa704a9c0f3f32d47bed9059e98c2
languageName: node
linkType: hard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this file

pedronfigueiredo and others added 16 commits May 12, 2023 14:16
* Implement CI to copy issue labels over to PRs

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* clean up

* clean up
* added extra margin for native token

* fixed lint errors

* added marginTop via css

* updated test

* added boxprops and margin bottom for tab component

* updated snapshot

* update asset list component
* devDeps: @storybook/*->6.5.16

* devDeps: [email protected]>2.1.1

* add lavamoat build policy override
* Addressed some lint issues.

* Worked on the mentioned lint issue.

* Worked on the CRLF lint issues.

---------

Co-authored-by: Brad Decker <[email protected]>
Co-authored-by: George Marshall <[email protected]>
* Fix account details editable label

* Fix font-weight of the password label

* Remove duplicate error

* Hide password warning on first screen after bad password, autofocus password field

* Fix jest failure

* Restore className
* adds mmi logic to home container

* adds code fences to home component

* adds code fences to home component

* lint fix

* lint fix

* updates fences and runs prettier

* version bump

* clean up code fence
… component: nft-details.js (MetaMask#18771)

* Update nft-details.js

* Update nft-details.test.js.snap

* Update nft-details.js

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/app/nft-details/nft-details.js

Co-authored-by: George Marshall <[email protected]>

* Update nft-details.test.js.snap

---------

Co-authored-by: legobeat <[email protected]>
Co-authored-by: Brad Decker <[email protected]>
Co-authored-by: George Marshall <[email protected]>
Co-authored-by: George Marshall <[email protected]>
…etaMask#18962)

* Remove border radius from network menu list

* Provide background color for test network avatars

* Make button size large

* Update ui/components/multichain/network-list-item/network-list-item.js

Co-authored-by: Nidhi Kumari <[email protected]>

* Fix lint

---------

Co-authored-by: Nidhi Kumari <[email protected]>
…hort names (MetaMask#18974)

* UX: Multichain: Ensure network picker renders properly for long and short network names

* Updatte ui/components/multichain/app-header/app-header.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/multichain/app-header/app-header.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/multichain/app-header/app-header.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/multichain/app-header/app-header.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/multichain/app-header/app-header.js

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/multichain/app-header/app-header.scss

Co-authored-by: George Marshall <[email protected]>

* Update ui/components/multichain/app-header/app-header.scss

Co-authored-by: George Marshall <[email protected]>

* Fix jest issue

---------

Co-authored-by: George Marshall <[email protected]>
georgewrmarshall and others added 23 commits May 12, 2023 14:16
… component in token-details-page.js (MetaMask#18741)

* Worked on issue MetaMask#17670 & MetaMask#18714 in file token-details-page.js in file

* Worked on issue MetaMask#17670 & MetaMask#18714 in file token-details-page.js in file

* Update token-details-page.js
NetworkController doesn't handle `eth_subscribe` or `eth_unsubscribe`
specially, but as it's supported by Infura, we want to make sure we
exercise these RPC methods in the network client tests, even if it is
just to ensure that they get passed through to the network.

We had tests for these RPC methods, but they were commented out in
c095b1accd00c8123f954633bf396ddea7b95eff when the network client code
was extracted to a separate file. At the time we were considering adding
subscription- and filter-based middleware to NetworkController, and so
we commented out the tests for `eth_subscribe` and `eth_unsubscribe`
temporarily until we could rewrite them in a way that would exercise the
new middleware. We reverted that change in
bd23a49, which meant that we could
restore the existing tests, but it appears that this task was not caught
during review. This commit takes care of restoring them.

Co-authored-by: legobeat <[email protected]>
* removed mmi fencing from copy icon

* updated snapshot
The detection of the Infura "blocked" status has been updated to apply
only to built-in networks. The message we show to users in this state
is meant only for Infura; we don't want to show it for third-party RPC
APIs that happen to use the same error response.

This brings the network controller further in alignment with the core
network controller.

This isn't tested, but it was found in the course of porting unit tests
from core to extension. It will be covered by these tests, which will
be added in the next PR.
…etaMask#18878)

* Fix script to build migrations

* Validate version is a number
* Build beta with mv3 enabled

* Ensure firefox manifest is an mv2 version

* Revert "Ensure firefox manifest is an mv2 version"

This reverts commit fed7479.

* Only create beta builds for the chrome platform

* Stop linting firefox for beta
* Show Bridge button in TokenOverview component

* Hide Swap button in token overview page when network is not supported
The range of browsers considered to be outdated has been updated to
match our latest browser support policy, which is ~2 years on Chrome,
and the most recent end-of-life extended support release on Firefox.

Comments have been added to help explain how these versions were chosen
as well.
* Show Bridge button in TokenOverview component

* Hide Swap button in token overview page when network is not supported
@thebinij thebinij requested review from a team and kumavis as code owners May 12, 2023 08:32
@thebinij
Copy link
Contributor Author

This is an old PR. Please Find New PR

@thebinij thebinij closed this May 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate components to TS: AvatarIcon