Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating prepare preview build script to account for react native packages #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: updating prepare preview build script to account for react native packages #138

wants to merge 2 commits into from

Conversation

georgewrmarshall
Copy link
Contributor

Description

Currently, our preview build process is failing because the root package.json's build script still references packages with the @metamask/ scope instead of @metamask-previews/ during preview builds.

  1. Reason for change: Preview builds are failing because they can't find @metamask/design-system-twrnc-preset and @metamask/design-system-react-native packages during the build process.
  2. Solution: Update the prepare-preview-builds.sh script to modify the root package.json's build script, replacing @metamask/ references with @metamask-previews/ during preview builds.

Related issues

Fixes: #102

Manual testing steps

  1. Create a PR with some changes
  2. Comment @metamaskbot publish-preview on the PR
  3. Verify that the preview build completes successfully
  4. Verify that the preview packages are published with the correct scope

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall changed the title fix: updating prepare preview build script to account for react nativ… fix: updating prepare preview build script to account for react native packages Nov 20, 2024
@georgewrmarshall georgewrmarshall self-assigned this Nov 20, 2024
@georgewrmarshall
Copy link
Contributor Author

@metamask-bot publish-preview

@georgewrmarshall
Copy link
Contributor Author

@metamask-bot publish-preview

3 similar comments
@georgewrmarshall
Copy link
Contributor Author

@metamask-bot publish-preview

@georgewrmarshall
Copy link
Contributor Author

@metamask-bot publish-preview

@georgewrmarshall
Copy link
Contributor Author

@metamask-bot publish-preview

@georgewrmarshall georgewrmarshall marked this pull request as ready for review November 21, 2024 21:37
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 21, 2024 21:37
@georgewrmarshall
Copy link
Contributor Author

@metamask-bot publish-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@georgewrmarshall georgewrmarshall

Labels
team-design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Publish Preview Build is Broken
1 participant
@georgewrmarshall