Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update design-system-react dependencies #118

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Nov 15, 2024

Description

This PR moves react from peer dependencies to dependencies following a discussion with the Wallet Framework team. This change ensures consistent dependency management and resolves issues related to compatibility and version conflicts in downstream integrations. Moving react to dependencies simplifies setup for users and ensures all necessary components are installed by default.

Related issues

Fixes: N/A

Manual testing steps

  1. Install dependencies and confirm that react is now listed as a primary dependency.
  2. Verify that no peer dependency warnings are issued related to react.
  3. Test the application for consistent functionality, ensuring no breaking changes in components relying on react.

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I’ve manually tested the PR (e.g., pull and build branch, run the app, test code changes).
  • I confirm that this PR addresses all acceptance criteria and includes necessary testing evidence, such as recordings or screenshots.

@georgewrmarshall
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link

socket-security bot commented Nov 15, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

@georgewrmarshall
Copy link
Contributor Author

@metamaskbot publish-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant