Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

applied eslint rules from core monorepo and fixed the errors #172

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

kanthesha
Copy link
Contributor

Description

We are in the process of migrating json-rpc-engine repo into core monorepo. Before migrating, we want to make sure the source repo is aligned in terms of eslint versions and rules.

In this PR,

  • Applied eslint rules from the core monorepo
  • Fixed errors due to new eslint rules from the core monorepo

References

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-import-resolver-typescript 2.7.1 None +0 59.9 kB jounqin

@kanthesha kanthesha marked this pull request as ready for review October 18, 2023 12:21
@kanthesha kanthesha requested a review from a team as a code owner October 18, 2023 12:21
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kanthesha kanthesha merged commit 7d0865b into main Oct 18, 2023
16 checks passed
@kanthesha kanthesha deleted the apply-eslint-rules-from-core branch October 18, 2023 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants