This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Switch license to MIT and apply package.json constraints ahead of migration to core monorepo #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e monorepo migration
MajorLift
force-pushed
the
230928-switch-license-to-mit-apply-packagejson-constraints
branch
from
4325fc8 to
d38f8fa
Compare
|
The MIT license change would require sign-offs from past contributors (stretching past the git history of this repository). See #13 |
|
Would it be acceptable to keep the license as ISC in the last release here (probably 2.2.0), and switch to MIT in core once the package has been migrated? It feels like that would be sidestepping the sign-off requirements, and I'm not sure if there are issues that could be caused by taking that route. |
|
Closing and keeping license as ISC. |
legobeat
deleted the
230928-switch-license-to-mit-apply-packagejson-constraints
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
package.json.References