Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Variable Naming Sprint: Part 6 #229

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mikecooke77
Copy link
Collaborator

@mikecooke77 mikecooke77 commented Oct 8, 2024

Description

Part of https://github.com/JCSDA-internal/oops/issues/2737

Renames the following variables:

  • surface_temperature -> air_temperature_at_2m
  • skin_temperature -> skin_temperature_at_surface

Dependencies - to be merged

waiting on these repos:
build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/1285
build-group=https://github.com/JCSDA-internal/vader/pull/279
build-group=https://github.com/JCSDA-internal/ufo/pull/3487
build-group=JCSDA-internal/ufo-data#454
build-group=https://github.com/MetOffice/jjtests/pull/52
build-group=https://github.com/JCSDA-internal/lfric-jedi/pull/912
build-group=https://github.com/JCSDA-internal/ops-um-jedi/pull/237

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@mikecooke77 mikecooke77 changed the title Model Variable Naming Sprint: Part 7 Model Variable Naming Sprint: Part 6 Oct 9, 2024
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@matthewrmshin matthewrmshin merged commit 03142ae into develop Oct 10, 2024
5 checks passed
@matthewrmshin matthewrmshin deleted the feature/variable_names_part6 branch October 10, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants