-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to work with changes to UFO filters #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this all looks good to me.
As discussed in Teams, I'm seeing some failures in sith/malak kgo runs using a build based on this PR and friends. Not sure if related or not. |
This is to do with validation of yamls and old settings which are now failing in the constructor. I don't understand why they were not failing before. @ctgh has kindly agreed to look into this next week. Sorry I hadn't done malak or sith testing. |
Introduction
This PR includes changes needed for some work in oops and ufo to move the filter factory to ufo.
There are also associated changes needed in orca-jedi and nemo-feedback which @ctgh has been working on.
Dependencies
build-group=https://github.com/JCSDA-internal/oops/pull/2760
build-group=https://github.com/JCSDA-internal/ufo/pull/3475
build-group=MetOffice/nemo-feedback#72
build-group=MetOffice/orca-jedi#121
build-group=https://github.com/MetOffice/jjdocs/pull/224