Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radar reflectivity #223

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Radar reflectivity #223

merged 3 commits into from
Oct 2, 2024

Conversation

ctgh
Copy link
Collaborator

@ctgh ctgh commented Aug 23, 2024 •
edited
Loading

This PR makes various changes to opsinputs to allow radar reflectivity processing:

  • Add RadarZ Varobs and CX namelists.
  • Update the Varobs and CX writers.
  • Add a variety of specific and more general ctests.
  • Update the netCDF generation script and add some new netCDF test files.

Coordinate merge

Please merge at the same time as:

PJLevensMO
PJLevensMO approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@PJLevensMO PJLevensMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Chris

@matthewrmshin
Copy link
Collaborator

Is this a coordinate merge with MetOffice/sith#374?

@matthewrmshin
Copy link
Collaborator

(I'm seeing some sith/malak kgo compare failures for kgo_glu* runs with an mo-bundle build with this branch + jjaux PR. Not sure if they are expected or not. I'll attempt to re-run with isolated changes to understand cause.)

matthewrmshin
matthewrmshin approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@matthewrmshin matthewrmshin merged commit 7614ded into develop Oct 2, 2024
5 checks passed
@matthewrmshin matthewrmshin deleted the feature/radar_reflectivity branch October 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJLevensMO PJLevensMO PJLevensMO approved these changes

@DJDavies2 DJDavies2 DJDavies2 approved these changes

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@adammaycock adammaycock Awaiting requested review from adammaycock adammaycock is a code owner

@mikecooke77 mikecooke77 Awaiting requested review from mikecooke77 mikecooke77 is a code owner

@yaswant yaswant Awaiting requested review from yaswant yaswant is a code owner

@ReubenHill ReubenHill Awaiting requested review from ReubenHill

Assignees

@ctgh ctgh

Labels
coordinated merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctgh @matthewrmshin @DJDavies2 @PJLevensMO