Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config lines that cause failure #222

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

matthewrmshin
Copy link
Collaborator

Following JCSDA-internal/ufo#3438, we have failures that look like:

74/152 Test  #75: test_opsinputs_varobswriter_ukvnamelist_surfacecloud ......................***Failed

...

�[31mTest "ufo/ObsFilters/testFilters" failed with unhandled exception: Column 'field':
  received: [15,15,15,15,15,15,15,15,15]
  expected: [15,15,15,15,15,15,15,15,15,15,15,15]�[0m
Completed case 0: ufo/ObsFilters/testFilters
  FAILED: ufo/ObsFilters/testFilters
1 tests failed out of 1.
Finished running the unit tests, result = 1
SurfaceCloud :  no output

This change fixes the failure.

Suite output with this fix. http://fcm1/cylc-review/taskjobs/frsn/?suite=mobbm-fixopsinputs

  • The suite is still running as I am write this, but the ctest_all_opsinputs__* tasks have all succeeded.

Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. cc @PJLevensMO for information.

@matthewrmshin
Copy link
Collaborator Author

I'll merge to prevent daily build issues.

@matthewrmshin matthewrmshin merged commit ac8b4eb into develop Aug 16, 2024
6 of 8 checks passed
@matthewrmshin matthewrmshin deleted the bugfix/fix-test branch August 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants