Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global surface CX namelist #208

Merged
merged 4 commits into from
May 22, 2024
Merged

Update global surface CX namelist #208

merged 4 commits into from
May 22, 2024

Conversation

ctgh
Copy link
Collaborator

@ctgh ctgh commented May 21, 2024

Explicitly list the fields in the global surface CX namelist. This follows the UKV namelist but adds three more required fields: cloud_bulk, cf and cl.

The existing opsinputs ctest is unchanged.

Sith global KGO output: http://fcm1/cylc-review/taskjobs/chthomas/?suite=sith-cx-global%2Frun3

(Not shown) sith UKV and malak global KGOs are also unaffected.

Fixes #155

Copy link
Contributor

@JoanneAWaller JoanneAWaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctgh for making the cx list explicit, it is much clearer than before.

Copy link
Contributor

@ReubenHill ReubenHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Just one comment to address

etc/global/cx/Surface.nl Show resolved Hide resolved
Copy link
Contributor

@ReubenHill ReubenHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctgh
Copy link
Collaborator Author

ctgh commented May 22, 2024

Thanks for both of your reviews!

@ctgh ctgh merged commit bae4d46 into develop May 22, 2024
6 checks passed
@ctgh ctgh deleted the feature/global_surface_cx branch May 22, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use explicit CX namelist for global surface observations
3 participants