Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove literal kinds #202

Merged
merged 1 commit into from
May 7, 2024
Merged

Remove literal kinds #202

merged 1 commit into from
May 7, 2024

Conversation

DJDavies2
Copy link
Collaborator

Resolves #138. I don't think there are any other cases. c_int seems most consistent with everything else.

Test output:

http://fcm1/cylc-review/taskjobs/frwd?&suite=opsinputs-138

Copy link
Collaborator

@mikecooke77 mikecooke77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change

Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@ctgh ctgh merged commit 0257a80 into develop May 7, 2024
4 of 5 checks passed
@ctgh ctgh deleted the bugfix/138 branch May 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer literals used for kind values
3 participants