Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add clang container to CI workflow #184

Merged
merged 3 commits into from
Oct 3, 2023
Merged

add clang container to CI workflow #184

merged 3 commits into from
Oct 3, 2023

Conversation

yaswant
Copy link
Collaborator

@yaswant yaswant commented Sep 29, 2023

Use JCSDA clang continer in CI workflow

@yaswant yaswant self-assigned this Sep 29, 2023
matthewrmshin
matthewrmshin approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. CI output looks sensible.

ctgh
ctgh approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I haven't followed all of the syntax but the output looks good.

@yaswant yaswant merged commit ca7c891 into develop Oct 3, 2023
5 of 6 checks passed
@yaswant yaswant deleted the feature/clang branch October 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecooke77 mikecooke77 mikecooke77 approved these changes

@ctgh ctgh ctgh approved these changes

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@DavidSimonin DavidSimonin Awaiting requested review from DavidSimonin

@james-cotton james-cotton Awaiting requested review from james-cotton

Assignees

@yaswant yaswant

Labels
enhancement New feature or request INFRA ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaswant @matthewrmshin @ctgh @mikecooke77