-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full paths in FC #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change which tackles a known usage pattern. There is still the issue of compiler executables being versioned, e.g. myfortran-x.y.z
but that can be left 'till later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sensible to me and I can see you've added the Optional label requested by Matthew so I think everything is good
Hi Scott, the build tests on the merge are failing with |
Fixed up the typing (the |
Changes requested have been made so dismissing this review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes now pass unit tests, thanks
Allow FC to be a full compiler path
Use LD for the linker in zero-config builds
Fixes #275