Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full paths in FC #276

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Support full paths in FC #276

merged 4 commits into from
Jan 15, 2024

Conversation

ScottWales
Copy link
Contributor

Allow FC to be a full compiler path

Use LD for the linker in zero-config builds

Fixes #275

Copy link
Collaborator

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change which tackles a known usage pattern. There is still the issue of compiler executables being versioned, e.g. myfortran-x.y.z but that can be left 'till later.

source/fab/cli.py Outdated Show resolved Hide resolved
Copy link

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me and I can see you've added the Optional label requested by Matthew so I think everything is good

@james-bruten-mo
Copy link

Hi Scott, the build tests on the merge are failing with Argument 1 to "_generic_build_config" has incompatible type "Union[Path, Any, None]"; expected "Path". I assume you now only want to call _generic_build_config from cli_fab when folder is not None. Cheers

@ScottWales
Copy link
Contributor Author

Fixed up the typing (the Optional[] on folder is needed to make the command line entry_point work)

@james-bruten-mo james-bruten-mo dismissed MatthewHambley’s stale review January 15, 2024 08:22

Changes requested have been made so dismissing this review

Copy link

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes now pass unit tests, thanks

@james-bruten-mo james-bruten-mo merged commit 2cbec69 into MetOffice:master Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$FC should allow the full path to compilers
3 participants