LFRic Apps apply upgrade macros script (Part 2) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked by the first part, but may as well go into review in parallel |
cameronbateman-mo
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Issue #37 and building on #38.
Blocked by #38
Building on the initial script added in #38, this PR adds the code to run the rose commands to apply the new macro and validate the metadata. It also adds unit tests for the entire script (these should be set up for CI but I think we should leave that to it's own ticket and have a coherent setup for the repo).
View just the "add rose commands and unit tests" commit to see the difference between #38 and this.
See #38 for additional links and instructions on testing.