Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Sessions should stay open even if snowflake is idle for hours #272

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

visch
Copy link
Member

@visch visch commented Oct 10, 2024

Fixes #270

@visch visch marked this pull request as ready for review October 10, 2024 16:42
Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@visch looks good to me!

@visch
Copy link
Member Author

visch commented Oct 10, 2024

We could put this behind a configuration flag.

They removed this as a default setting (Anything that's alive for long periods of time idle you probably don't want Keep Alive going) here
https://github.com/snowflakedb/snowflake-connector-python/blob/aeb771ccb581541caa54717b04468793f02a23c6/DESCRIPTION.md?plain=1#L491

Not super clear why auth wouldn't reauth to me but 🤷

feast-dev/feast#4611 is also tracking this

@cjohnhanson cjohnhanson merged commit 5d88337 into MeltanoLabs:main Oct 10, 2024
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication Expired
3 participants