feat: add private key authentication #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miloszszymczak this looks great, thanks for the PR! The CI tests didnt run since the PR is from a fork but I ran them locally and all passed so there shouldnt be any regressions. I dont have private key auth set up to test it. Do you have it working on your end? |
|
@pnadolny13 yes, I actually made the fork to use it directly in my project and decided later to properly adjust non-code stuff to make a pull request so I can use the official package |
|
Great! I reviewed the code, all tests pass, and @miloszszymczak confirmed that the changes are working for them. I'll go ahead and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two additional properties to config allowing to use key pair authentication as described in Key pair authentication
It can be used instead of password and decrypts the key with a passphrase if needed.