issue: 4207369: EOFError while extracting logs #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drorlevy
reviewed
Dec 19, 2024
plugins/ufm_log_analyzer_plugin/src/loganalyze/logs_extraction/tar_extractor.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/src/loganalyze/logs_extraction/tar_extractor.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/src/loganalyze/logs_extraction/tar_extractor.py
Outdated
Show resolved
Hide resolved
boazhaim
reviewed
Dec 19, 2024
plugins/ufm_log_analyzer_plugin/src/loganalyze/logs_extraction/tar_extractor.py
Outdated
Show resolved
Hide resolved
boazhaim
approved these changes
Dec 19, 2024
drorlevy
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Skip corrupted inner tar files.
Why ?
An EOFError is expected when running the analyzer on a tar file where one of the inner tar files is corrupted, but the outer tar file is valid.
How ?
Add checking validity.
Testing ?
Manually, run the analyzer and check the output pdf
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests