Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage API - listen sockets support #218

Open
wants to merge 5 commits into
base: vNext
Choose a base branch
from

Conversation

pasis
Copy link
Member

@pasis pasis commented Aug 21, 2024

Description

Please provide a summary of the change.

What

Subject: what this PR is doing in one line.

Why ?

Justification for the PR. If there is existing issue/bug please reference.

How ?

It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

@pasis pasis added the draft Not to review yet label Aug 21, 2024
@pasis pasis force-pushed the storage-api-listen branch from ac17ffc to b166325 Compare August 21, 2024 20:11
@pasis pasis force-pushed the storage-api-listen branch from 5ffa993 to 114890e Compare September 28, 2024 14:01
@benjarvis
Copy link

Thanks for doing this.

FWIW I tried using it and it seems to work pretty well, now that the xlio socket API can be used end to end...

https://www.linkedin.com/posts/ben-jarvis-132b2220_adding-nvidia-xlio-support-200gbe-with-one-activity-7254114887340105728-M3Ak?utm_source=share&utm_medium=member_desktop

@pasis pasis force-pushed the storage-api-listen branch from 114890e to 930ad2a Compare November 15, 2024 13:19
in_protocol_t represents several values and doens't have to be 4 bytes
in size. Reducing it to 2 bytes allows to utilize flow_tuple layout more
efficiently.

Signed-off-by: Dmytro Podgornyi <[email protected]>
During guided migration between xlio_poll_groups, between detach and
attach operations the new RX packets arrive to the respective listen
socket due to 3T steering. Drop such packets with TCP RST, so the
packets can be retransmitted eventually and the TCP stream recover.

Signed-off-by: Dmytro Podgornyi <[email protected]>
@pasis
Copy link
Member Author

pasis commented Nov 18, 2024

Thanks for doing this.

FWIW I tried using it and it seems to work pretty well, now that the xlio socket API can be used end to end...

https://www.linkedin.com/posts/ben-jarvis-132b2220_adding-nvidia-xlio-support-200gbe-with-one-activity-7254114887340105728-M3Ak?utm_source=share&utm_medium=member_desktop

Hi @benjarvis, thank you for sharing your results. 200Gbits with a single TCP connection is amazing result!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Not to review yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants