add couchbase support #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 merge plz? |
|
@zeitlinger might be worth to squash the commits first. you have multiple commits with the same message |
| + this is not a backend | ||
| + it just executes programs (usually bash scripts) in a directory | ||
| + the program name is used as the metric name | ||
| + the output of the program must be numeric |
There was a problem hiding this comment.
this part should probably go to a different branch, isn't related to the couchbase support part
There was a problem hiding this comment.
Yes, this referes to nagiorelic.
|
please don't merge this branch, it's broken. #457 builds up on this, fixes everything, and adds many more features. We're using it at @ Rounds for some time now and it's working great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.