Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise layout WeatherBanner.qml #78

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

pagism
Copy link

@pagism pagism commented Dec 1, 2024

Adjust the horizontal placement for line 1 and 2 in weather event view.
Closes #75

@Olf0
Copy link
Member

Olf0 commented Dec 1, 2024

Thank you very much: This is looking good. I will review this in detail the next couple of days.

@Olf0 Olf0 changed the title #75 optimise layout WeatherBanner.qml Optimise layout WeatherBanner.qml Dec 2, 2024
@Olf0
Copy link
Member

Olf0 commented Dec 2, 2024

I was too curious.

  1. On an [email protected] in portrait orientation
    meecast-eventview_xperia-x_portrait_pr78

  2. On an [email protected] in landscape orientation
    meecast-eventview_xperia-x_landscape_pr78

Excellent! But now only 7 days are displayed in landscape orientation, resulting in plenty of space to the left and right!?!

Now I just have to go through the code changes, also because I want to understand them. With a bit of luck, I may also understand what causes the "slight shift to the left", which is also present in above screenshots.

@Olf0 Olf0 self-assigned this Dec 2, 2024
@pagism
Copy link
Author

pagism commented Dec 2, 2024

The margins will need to be readjusted very finely, i.e. the spaces of each item as well the gaps between them need to be calculated, the remaining space is the margin. Lines 132/134 do that but I am not fully an expert on QML.

On landscape mode shows 7 days because the code has 7 entries in the "forecast_row", I found the indexing of days strange, e.g. 96-102. All this should be converted to a ListItem or something like that and the forecast_row to iterate ("deligate in terms of QML?) through that list?

@vasvlad vasvlad merged commit 0fb8a67 into Meecast:sailfishos Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants