Fix infinite scrolling of results on search page #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 40 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infinite scrolling on the search page currently does not work, throwing the javascript exception of invalid json and showing the paginator instead. this updates the controller to handle xml requests
(this might sound familiar, it also isn't working by the same mechanic on user pages so expect that some time in the future)
based on similar work Benti did to get infinite scrolling working on tag pages
marked as draft as although I am getting the next page results, seeing some stuff missing. might've just messed up bringing the code over for this as it's a bit unique (can show a magazine box or user box or threads or microblogs etc). but almost thought I accidentally lost my changes so just wanted to get them up before I risk losing my work so far