Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw UnrecoverableMessageHandlingException on 4xx #1235

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Throw UnrecoverableMessageHandlingException on 4xx #1235

merged 2 commits into from
Nov 24, 2024

Commits on Nov 24, 2024

  1. Throw UnrecoverableMessageHandlingException on 4xx 

    When we try to deliver an activity to an inbox and receive a 4xx status code other than the 429 for rate limiting we now discard that message, so it will not get retried. This also doesn't count as a failed delivery to the instance anymore, because the instance is up, it just didn't accept the activity. TransportExceptions are now caught as well, since those are the ones we get when an instance is down
    @BentiGorlich
    BentiGorlich committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    ec8d4b4 View commit details
    Browse the repository at this point in the history

  2. Add a debug log for unrecoverable errors, use constant 

    - The log part will is already partly covered by the  `ApHttpClient::logRequestException` method, but it will be helpful regardless
- use a constant for the 429 rate limited http status code
    @BentiGorlich
    BentiGorlich committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    d5760b6 View commit details
    Browse the repository at this point in the history