-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename remaining article to thread #1138
base: dev/new_features
Are you sure you want to change the base?
Conversation
Ok I will look at it closer tomorrow. Code wise it looks good now |
This pr is less urgent than the 1.7.x fixes. No worries here. It's not really a bug fix. |
d07c5c3
to
fa6f302
Compare
Co-authored-by: Melroy van den Berg <[email protected]>
fa6f302
to
09a90b4
Compare
Rebased |
ed923ae
to
9b44612
Compare
@melroy89 do you have an idea why there are so many commits linked to this PR? Doesn't really make sense to me especially since there are multiple commits of other PRs |
yeah, I also found this weird. Maybe something went wrong with merging/rebasing? |
I might need to redo this all, and revert several commits via reset hard or something. And try to rebase again. Maybe I started on the main branch initially? And later changed to the new |
Rename all the remaining keywords from
article(s)
tothread(s)
. Making the code more consistent.Which also means I renamed the new valid link for creating a new thread:
new/thread
in the URL (same for the API).This PR also finally solves the translation strings that then where still have the key
article
,articles
,edit_article
(which was always missing btw),add_new_article
, etc. To the new keys:type.thread
,thread
,threads
,add_new_thread
and finallyedit_thread
.To be backwards compatible with existing data in the database (specifically the
type
column in theentry
table), we keep thearticle
string in theresolveType()
function, so t he old string "article" or "articles" are still valid. Same for some Twig templates, we extend with anotheror
for backwards compatibly for now.The next logical follow-up would be to rename
entry
as well later.