Allow admins to view user IP addresses in the admin panel users table and users page #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
|
I thought that we fixed the trusted proxy problem a long time ago :O |
not sure how since it was never configured, lol |
added 5 commits
August 9, 2024 09:55
ghost
changed the title
BentiGorlich
requested changes
Aug 10, 2024
There was a problem hiding this comment.
I have a few things that I would like to see changed:
- I would prefer if you'd move the trusted proxy stuff in its own PR
- Since we are already changing the db schema to have the IP-addresses of users we should create a new table for IP addresses and one that makes the references between users and IPs. That would have a few benefits:
- accounts for multiple devices
- The most important IP imo is the one used to register an account. At least that is the one I would be interested in for spam detection.
- since this is personal information I think we should create a scheduled job to look for IP addresses that have been used over a year ago and deleting them
- we can use the same table for IP-blocks in the future
- easier to lookup all users with a specific IP
I think this would be a really good addition for admins to prevent spam right upon account creation
Co-authored-by: BentiGorlich <[email protected]>
Co-authored-by: BentiGorlich <[email protected]>
ghost
marked this pull request as draft
|
Should we follow-up this PR? |
|
This PR is stale because it has been open 40 days with no activity. |
|
Rebased.. |
|
Fixed PHP cs fixer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces admin ability to view local users IP addresses as resolved from
src/Service/IpResolver.php:A user's IP address is updated on:
I also added local user email and IP to the user's page for admins:
Other things:
I noticed the GitHub authenticator was missing the IP being set in the user dto which will cause the registration limiter to be ineffective, so I added it in to be consistent with the other authentication mechanisms.
Closes: #833