Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS1.3 write early data #6542

Closed
wants to merge 5 commits into from

Conversation

xkqian
Copy link
Contributor

@xkqian xkqian commented Nov 7, 2022

Add API mbedtls_ssl_write_early_data()
Add API mbedtls_ssl_get_early_data_status()
Write early data at the first flight.
Add machine stat: MBEDTLS_SSL_EARLY_APP_DATA

@xkqian xkqian linked an issue Nov 7, 2022 that may be closed by this pull request
1 task
@yuhaoth
Copy link
Contributor

yuhaoth commented Nov 17, 2022

To match RFC, early data MUST be written after ClientHello ASAP. There is an issue for hybrid mode which described in #6486 (comment) .

It should be dig and figure out best solution.

@tom-daubney-arm
Copy link
Contributor

We are now converting older PRs to draft PRs where the following conditions are met: They have not been updated in the last 3 months, and they need more than non-trivial work to complete.

@tom-daubney-arm tom-daubney-arm added the historical-reviewed Reviewed & agreed to keep legacy PR/issue label Jun 15, 2023
@tom-daubney-arm tom-daubney-arm marked this pull request as draft June 15, 2023 11:05
@xkqian xkqian force-pushed the tls13_write_early_data branch 4 times, most recently from e732ba2 to 4221aba Compare October 27, 2023 06:26
@xkqian xkqian force-pushed the tls13_write_early_data branch 4 times, most recently from 3741885 to d36698d Compare November 7, 2023 08:49
@yuhaoth
Copy link
Contributor

yuhaoth commented Nov 21, 2023

To match RFC, early data MUST be written after ClientHello ASAP. There is an issue for hybrid mode which described in #6486 (comment) .

It should be dig and figure out best solution.

For the time being, we should only allow early data in resumption and tls13 only mode for client side

@tom-cosgrove-arm tom-cosgrove-arm marked this pull request as ready for review November 28, 2023 09:17
@tom-cosgrove-arm tom-cosgrove-arm removed historical-reviewed Reviewed & agreed to keep legacy PR/issue needs-ci Needs to pass CI tests labels Nov 28, 2023
@tom-cosgrove-arm tom-cosgrove-arm changed the title Tls13 write early data TlS13 write early data Dec 11, 2023
@tom-cosgrove-arm tom-cosgrove-arm changed the title TlS13 write early data TLS1.3 write early data Dec 11, 2023
@ronald-cron-arm
Copy link
Contributor

Superseded by #8755 and #8760.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS 1.3 client: Add support for early data writing
5 participants