Support Unicode in .function files #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of our source files are encoded in UTF-8. We have other scripts that make this assumption. We don't want to depend on the platform encoding. This fixes a bug whereby non-ASCII characters in .function files led to an error when writing the generated C file. Fix #64. Signed-off-by: Gilles Peskine <[email protected]>
We had a home-made FileWrapper class, written in the days of Python 2, whose main purpose was to add line numbers. Use the standard class fileinput instead. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unit test code generator, use utf-8 when opening text files. Get rid of some cruft dating from the Python 2 days. Fix #64.
PR checklist