Fix decimal parsing for non-dot decimal point #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rickebo thank you for your contribution. The changes look good and I can merge the PR, however, I will not be able to push a new Nuget until the failing tests have been fixed. |
|
Looks like the API is returning a 401 when requesting quotes, and doesn't appear to be related to my change. I started working on a solution by requesting a crumb from the API but I don't have time to finish it currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages use other decimal points than
.. Yahoo uses the dot as a decimal point in its API though, and therefore, parsing decimals with justdecimal.TryParsefails when OS is set up to use other characters such as,. This change forces decimals to be parsed using the dot as decimal point to fix the problem.