Refactor UI components #135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushiiMachine
requested changes
Apr 14, 2023
| viewModelScope.launch { | ||
| val guild = guilds.fetchGuild(persistentGuildId) | ||
| ?: return@launch | ||
| persistentDataStore.observeCurrentGuild() |
There was a problem hiding this comment.
this does not need to be updated when the current guild changes (it won't except for a tiny edge case)
it should stay the same for as long as the screen is open
should probably add some getGuildId() or something to persistent store
There was a problem hiding this comment.
I can just make it get the last value, no problems with that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HomeScreento individual panelsHomeScreento callload()functions when data changes. Instead, ViewModels observe data changes themselves and update the UI accordingly. This should ensure that all data is updated properly.