Quality of life changes around JSONL & MongoDB #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ml-evs
commented
Oct 30, 2024
•
ml-evs
commented
- Better error handling and logging on JSONL insert
- Parallel inserts from MongoDB
- Convenience methods and config for creating indexes: nothing changes by default, but indexes can now be made when inserting from JSONL data.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
==========================================
- Coverage 90.80% 90.67% -0.14%
==========================================
Files 75 75
Lines 4819 4845 +26
==========================================
+ Hits 4376 4393 +17
- Misses 443 452 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ml-evs
force-pushed
the
ml-evs/some-qol-fixes
branch
from
dd2c71e
to
43ef254
Compare
ml-evs
force-pushed
the
ml-evs/some-qol-fixes
branch
7 times, most recently
from
451b4bc
to
2da4263
Compare
- provide method for creating indexes - use unordered batch inserts - refactor abstract insert method to be clearer
ml-evs
force-pushed
the
ml-evs/some-qol-fixes
branch
3 times, most recently
from
7e656f2
to
11e6bf4
Compare
- Make creation of default index configurable - Lint index creation - Add wrapper call in Elasticsearch to create_default_index - Add hacky test for index creation - Make index before insert
ml-evs
force-pushed
the
ml-evs/some-qol-fixes
branch
from
11e6bf4
to
08e0108
Compare
|
I'm going to merge, can potentially backport these changes to 1.1.x but not super important, otherwise will wait for 1.2.x release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.