Changes to property definitions #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaitkus
reviewed
Feb 20, 2023
Co-authored-by: Antanas Vaitkus <[email protected]>
vaitkus
reviewed
Feb 20, 2023
vaitkus
reviewed
Feb 20, 2023
Co-authored-by: Antanas Vaitkus <[email protected]>
vaitkus
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor adjustments to our property definitions according to what has been discussed in issues:
x-optimade-property/property-uriinto simply$id, which is the JSON Schema standard way of communicating the same thing, see Replace property definitions x-optimade-property/property-uri with just an outer "$id" key? #442.x-optimade-typeto specify the OPTIMADE data type. It was concluded in SMILES property #392, SMILES data type #436 that this is necessary if we do not want to make things very complicated when/if we want/need to support more complex data types.The definition of the
typefield has thus been completely rewritten to take into account the quite direct relationship tox-optimade-property.(Note: I mentioned earlier that I would take this in #445, but upon realizing that I had to do rather significant edits here, I decided not to mix the two up.)
Edit: Oh, and this PR also fixes a bug in that the mandatory
x-optimade-property/property-formatwas not included in the response example.