doc/user: promote COMMENT ON to GA #30679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also wanted to change |
ParkMyCar
approved these changes
Dec 2, 2024
kay-kim
reviewed
Dec 2, 2024
|
|
||
| <!-- RELATION_SPEC mz_internal.mz_comments --> | ||
| | Field | Type | Meaning | | ||
| | -------------- |-------------| -------- | | ||
| | `id` | [`text`] | The ID of the object. Corresponds to [`mz_objects.id`](../mz_catalog/#mz_objects). | | ||
| | `object_type` | [`text`] | The type of object the comment is associated with. | | ||
| | `object_sub_id`| [`integer`] | For a comment on a column of a relation, this is the column number. For all other object types this column is `NULL`. | | ||
| | `object_sub_id`| [`integer`] | For a comment on a column of a relation, the column number. `NULL` for other object types. | |
There was a problem hiding this comment.
For parallelism, it probably should be more
Suggested change
| | `object_sub_id`| [`integer`] | For a comment on a column of a relation, the column number. `NULL` for other object types. | | |
| | `object_sub_id`| [`integer`] | For a comment on a column of a relation, the column number. For other object types, `NULL`. | |
or
Suggested change
| | `object_sub_id`| [`integer`] | For a comment on a column of a relation, the column number. `NULL` for other object types. | | |
| | `object_sub_id`| [`integer`] | The column number for a comment on a column of a relation. `NULL` for other object types. | |
But, recognizing that these pages are slightly loose ... so, feel free to ignore.
kay-kim
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ParkMyCar: it seems like the remaining task is to stabilize
mz_comments. Marked that as a TODO under #8394.