Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Equivalences::minimize take Option<Slice> #30635

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frankmcsherry
Copy link
Contributor

The minimize function for Equivalences took an &Option<Vec<T>>, which made sense in several initial call sites, but has led to the need to clone various things just to get an option around a vector. This PR changes the argument to be Option<&[T]>, which one can arrive at without cloning. The downside is a bit more chatter converting the optional vector to an optional slice, but .. just better practice anyhow.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant