Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Massdrop LED instruction code, add new effects #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

just-another-jxliu
Copy link

@just-another-jxliu just-another-jxliu commented Dec 7, 2018

Do not merge

TODOs

  • Re-add LED indicators (caps lock, etc.)
  • Get reviewed by Patrick
  • Last step: create pull request with these changes and previous changes to be merged into main QMK repo.

The goal is for these changes to be merged back to the main QMK repo.

Contains the following changes:

  • Removed LED instruction code from arm_atsam/led_matrix.c. Moved to keyboards/massdrop/led_instructions.c.
  • Added static color map, rgb_matrix_set_color(), and rgb_matrix_set_color_all() to arm_atsam/led_matrix.c. LED loop still processes 15 per loop. rgb_matrix_set_color functions are a simpler interface for other users to use if they don't want to use LED instructions.
  • Changed animation speed to be specified as period in milliseconds. Previously it was specified in approximately deciHertz.
  • Changed animation offset to be based on clock ms instead of disp frame.
  • Changed animation speed increase/decrease steps to be +/-10% regardless of current animation speed.
  • Allow animation speed to be specified per pattern. First instruction in a pattern can specify ms param. (Design here is a bit iffy...)
  • New effects:
    • Pattern axis/direction: right to left, top to bottom, bottom to top, X+Y axis together
    • Animate: in pattern direction, opposite of pattern direction, over time
    • Blends: add, multiply, divide, RGB permutations
  • Added array assocations for: Matrix row/col <-> LED ID <-> Keymap row/col (ALT and CTRL keyboards)
  • Allow built-in LED patterns to be overridden by equivalent file in user's keymap directory.

Keymap updates:

  • Added example keymaps showing (1) setting RGB without instructions, (2) reactive RGB layered on top of patterns, (3) overriding the built-in patterns.
  • Updated reywood's keymap to use the centralized matrix/LED/keymap arrays and to remove unused LED instructions/patterns.

From master merge

  • Maintained led_animation_orientation variable. It still swaps X and Y axes.

pschmuckal pushed a commit that referenced this pull request Dec 26, 2019
* Translated faq.md and added all other files (copy from English)

* Translated driver_installation_zadig.md in French

* Translated faq_build.md in French

* Translated faq_debug in French

* Translateed faq_general.md in French

* Translated first part of faq_keymap.md

* Renamed docs/fr-FR folder to docs/fr-fr

* Finished translation of faq_keymap.md

* Update faq_build.md

* Review (#3)

* Review

* Update docs/fr-fr/faq_keymap.md

* Update docs/fr-fr/faq_debug.md

* Fix some PR comments

Co-Authored-By: Noan Mousy <[email protected]>
Co-Authored-By: Wermeille Bastien <[email protected]>
Gentoli pushed a commit to Gentoli/qmk_firmware that referenced this pull request Jul 23, 2020
* Initial upload - sedan and coupe keyboards

* Update coupe.h

* Update coupe.h

* Update coupe.h

* Update sedan.h

* Update keyboards/clawsome/coupe/readme.md

* Update keyboards/clawsome/sedan/config.h

* Update keyboards/clawsome/sedan/config.h

* Update keyboards/clawsome/coupe/config.h

* Update keyboards/clawsome/sedan/readme.md

* Update keyboards/clawsome/sedan/info.json

* Update keyboards/clawsome/sedan/readme.md

* Update keyboards/clawsome/coupe/readme.md

* Update keyboards/clawsome/coupe/info.json

* Update keyboards/clawsome/coupe/coupe.h

* Update keyboards/clawsome/coupe/info.json

* Update keyboards/clawsome/coupe/info.json

* Update keyboards/clawsome/coupe/keymaps/default/keymap.c

* Update keyboards/clawsome/sedan/info.json

* Update keyboards/clawsome/sedan/sedan.h

* Update keyboards/clawsome/sedan/rules.mk

* Update keyboards/clawsome/sedan/sedan.h

* Update keyboards/clawsome/sedan/keymap/default/keymap.c

* Update keyboards/clawsome/sedan/keymap/default/keymap.c

* Update keyboards/clawsome/coupe/rules.mk

* Update keyboards/clawsome/sedan/info.json

* Update keyboards/clawsome/sedan/info.json

* Rename keymap.c to keymaps.c

* Rename keymap.c to keymaps.c

* folder name updated

* updated keymaps

* remove erroneously added files

* extend keymap functionality

* Update config.h

* Update config.h

* added URL on line Massdrop#3 for image of Coupe

* Added URL to line Massdrop#3

* Update keyboards/clawsome/sedan/readme.md

* Update keyboards/clawsome/coupe/readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant