SW-261: Return to datatable and change CSV or columns #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now return to the datatable summary:
And then choose to either change the upload or the column source assignment:
Other changes:
Dataset is fetched upfront by middleware
There's a new middleware
fetchDataset
that calls the api to get a dataset with all currently available relations hydrated before each route executes. This simplifies having to worry about what to fetch in most cases. If we find that the response starts becoming too big or slow, we can look at making some of the relations optional, but currently it's like 20-30ms so I'm not expecting this to be an issue.Most GET/POST routes are now handled by the same controller
e.g.
We generally need the same or similar things for displaying the original page and errors after a form submit, so this reduces the amount of code duplication a fair bit.