Use url builder to generate all URLs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheelsandcogs
commented
Oct 16, 2024
| "confirm": "confirm", | ||
| "sources": "sources", | ||
| "source_confirmation": "source-confirmation", | ||
| "tasklist": "tasklist" |
There was a problem hiding this comment.
Technically these should never get used as the url builder skips attempting to translate URLs when the locale is English.
However, we'll need them as fallback if the Welsh is missing, and the Welsh language translations need the right keys in order to work, so it makes sense for the English translation file to have them as a source.
There was a problem hiding this comment.
PS - these must be flat - the builder translates each part of the path individually not as a whole.
wheelsandcogs
force-pushed
the
task/build-url
branch
from
21f6ec7 to
ab9ca9a
Compare
j-maynard
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies creating URLs by not having to worry about translation - just pass the builder the actual route and the expected locale, and it will return a URL string with the locale and a translated path.
If the current locale is English, it will just skip the path translation completely to save on the translation lookups.