Fixes missing strings, the odd bug and tasklist #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following feedback from Nicole I've updated the task list with status information and left a comment on the function to generate the tasklist to generate this on the backend. I've checked for missing error strings and added these in to the english translations file. The view dataset page has been tweaked so we can download the CSV files from the imports. This is useful for creating a better testing environment and will proves out that we can easily download CSVs from the Datalake via the backend to the frontend.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Update the frontend to match the backend
Add new env vars to deploy
src/dtos2/single-language/dataset.ts
Outdated
| archive?: string; | ||
| dimensions?: SingleLanguageDimension[]; | ||
| revisions: RevisionDTO[]; | ||
| datasetInfo?: DatasetInfoDTO; |
There was a problem hiding this comment.
This is fine for now, but I think the "standard" use case is probably always single language, and the "special" use case would be to return multiple languages?
e.g. I'm nearly always in either en or cy, the only time I might want both at the same time is viewing or exporting the entire nested object?
Following feedback from Nicole I've updated the task list with status information and left a comment on the function to generate the tasklist to generate this on the backend. I've checked for missing error strings and added these in to the english translations file. The view dataset page has been tweaked so we can download the CSV files from the imports. This is useful for creating a better testing environment and will proves out that we can easily download CSVs from the Datalake via the backend to the frontend.
…rontend into fix-bugs
|
Closing for weirdness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following feedback from Nicole I've updated the task list with status information and left a comment on the function to generate the tasklist to generate this on the backend.
I've checked for missing error strings and added these in to the english translations file. The view dataset page has been tweaked so we can download the CSV files from the imports. This is useful for creating a better testing environment and will proves out that we can easily download CSVs from the Datalake via the backend to the frontend.