Update src/views/publish/lookup-table-preview.ejs

Co-authored-by: Phil Moorhouse <[email protected]>
Marvell-Consulting · Dec 19, 2024 · 7e0fd96 · 7e0fd96
1 parent 79bd964
commit 7e0fd96
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 15 deletions.
diff --git a/src/controllers/publish.ts b/src/controllers/publish.ts
@@ -324,10 +324,7 @@ export const uploadLookupTable = async (req: Request, res: Response, next: NextF
                 logger.error('Something went wrong other than not matching');
                 logger.error(`Full error JSON: ${JSON.stringify(error, null, 2)}`);
                 res.redirect(
-                    req.buildUrl(
-                        `/publish/${dataset.id}/dimension-data-chooser/${dimension.id}/`,
-                        req.language
-                    )
+                    req.buildUrl(`/publish/${dataset.id}/dimension-data-chooser/${dimension.id}/`, req.language)
                 );
                 return;
             }
@@ -366,12 +363,7 @@ export const lookupReview = async (req: Request, res: Response, next: NextFuncti
                 case 'goback':
                     try {
                         await req.swapi.resetDimension(dataset.id, dimension.id);
-                        res.redirect(
-                            req.buildUrl(
-                                `/publish/${dataset.id}/lookup/${dimension.id}/`,
-                                req.language
-                            )
-                        );
+                        res.redirect(req.buildUrl(`/publish/${dataset.id}/lookup/${dimension.id}/`, req.language));
                     } catch (err) {
                         const error = err as ApiException;
                         logger.error(

diff --git a/src/views/publish/lookup-table-preview.ejs b/src/views/publish/lookup-table-preview.ejs
@@ -22,11 +22,7 @@
                         <tr class="govuk-table__row">
                             <% locals.headers.forEach(function(cell, idx) { %>
                                 <th scope="col" class="govuk-table__header">
-                                    <% if (cell.name === dimension.joinColumn) { %>
-                                        <%= cell.name %>
-                                    <% } else { %>
-                                        <%= t(`publish.lookup_table_review.column_headers.${cell.name.toLowerCase()}`) %>
-                                    <% } %>
+                                    <%= cell.name === dimension.joinColumn ? cell.name : t(`publish.lookup_table_review.column_headers.${cell.name.toLowerCase()}`) %>
                                 </th>
                             <% }); %>
                         </tr>