SW-183: move auth to backend and use jwt for protected routes #12

wheelsandcogs · 2024-08-30T16:29:02Z

This adds new routes and config to the backend that provide authentication via Google, OneLogin, and JWT tokens.

The Google and OneLogin providers are currently disabled for NODE_ENV=test. We can revisit this later if/when we have some kind of browser testing (playwright?).

I've done a bit of refactoring (sorry about that) to add a bit more (hopefully) logical structure.

src/route/auth.ts

test/healthcheck.test.ts

src/db/database-manager.ts

.github/workflows/node-test.yml

.gitignore

package.json

src/app.ts

src/controllers/blob-storage.ts

src/controllers/auth.ts

src/dtos/dataset-dto.ts

src/entities/csv-info.ts

src/entities/user.ts

src/enums/data-location.ts

src/middleware/passport-auth.ts

src/middleware/rate-limiter.ts

src/migrations/1725962477957-initial-schema.ts

src/controllers/datalake.ts

src/db/data-source.ts

src/dtos/revision.ts

src/enums/data-location.ts

Co-authored-by: Jamie Maynard <[email protected]>

j-maynard · 2024-09-11T12:59:49Z

src/route/healthcheck.ts


-const dataLakeService = new DataLakeService();
-export const healthcheck = Router();
+const healthcheck = Router();



We do need a complete / healthcheck to pass to Docker and the Container service to tell us when things aren't working. Really this should include checking we have the following:

Database connection

Datalake connection

BlobStorage connection

As these are required for the service to work and if they stop working for any reason its good to be able to look at the health check to see thats the case.

I agree, we should have a healthcheck/ for any connected services that we can use for monitoring.

I had to disable the datalake one temporarily because it is failing in CI when attempting to connect to your-storage-account-name.x.y.z endpoint to fetch creds.

j-maynard

This looks good to me 🚀

github-advanced-security bot found potential problems Aug 30, 2024

View reviewed changes

src/route/auth.ts Fixed Show fixed Hide fixed

wheelsandcogs added 10 commits September 9, 2024 13:55

move auth to backend and use jwt for protected routes

1a57933

fix ci issues

9b94a34

support onelogin attempt

df0f040

add cert dir

92ae4a3

ignore contents of certs dir

fb084ce

working onelogin auth

9c8ac6b

fix lint

25e8faf

don't need a certs dir for now

4b9813a

reuse existing logger

a5089af

all tests passing

d7453e9

wheelsandcogs force-pushed the SW-183 branch from 660ca66 to d7453e9 Compare September 10, 2024 15:36

github-advanced-security bot found potential problems Sep 10, 2024

View reviewed changes

test/healthcheck.test.ts Dismissed Show dismissed Hide dismissed

wheelsandcogs added 2 commits September 10, 2024 16:39

move onelogin setup inside provider flag

65da67b

fix db connection in github ci

4b33ea0

github-advanced-security bot found potential problems Sep 10, 2024

View reviewed changes

src/db/database-manager.ts Fixed Show fixed Hide fixed

wheelsandcogs added 2 commits September 10, 2024 17:00

remove debug log

c15a82f

ignore datalake connection for now

047dc88

wheelsandcogs changed the title ~~WIP - SW-183: move auth to backend and use jwt for protected routes~~ SW-183: move auth to backend and use jwt for protected routes Sep 10, 2024

disable datalake healthcheck in tests

1a04caf