release-please

⬆️(deps): Update dependency @types/node to v18.18.9 (#1232) #575

Triggered via push November 7, 2023 21:20

renovate[bot]

pushed 03041bf

master

Status Success

Total duration 49s

Artifacts –

release-please.yml

on: push

release-please

40s

Annotations

131 warnings and 3 notices

Class is exposed outside of its visibility scope: commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/AnalyzerStatus.java#L70

Class `Status` is exposed outside its defined visibility scope

Class is exposed outside of its visibility scope: commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/AnalyzerStatus.java#L63

Class `Status` is exposed outside its defined visibility scope

Redundant 'Collection.addAll()' call: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/formatting/GoogleStyle.java#L21

'addAll()' call can be replaced with parametrized constructor call

Constant values: github-bot/src/main/java/io/github/martinwitt/laughing_train/summary/PeriodicSummary.java#L133

Condition `result == null` is always `false`

Nullability and data flow problems: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java#L94

Argument `url` might be null

Nullability and data flow problems: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java#L22

Method invocation `getPath` may produce `NullPointerException`

Nullability and data flow problems: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/PointlessBooleanExpression.java#L72

Method invocation `equals` may produce `NullPointerException`

Default annotation parameter value: github-bot/src/main/java/io/github/martinwitt/laughing_train/summary/PeriodicSummary.java#L41

Redundant default parameter value assignment

Deprecated member is still used: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java#L290

Deprecated member 'withRemoveResultDir' is still used

Double negation: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/array_can_be_replaced_with_enum_values/ArrayCanBeReplacedWithEnumValuesAnalyzer.java#L45

Double negation in `!(declaration.getEnumValues().size() != count)`

Statement with empty body: code-transformation/src/main/java/spoon/reflect/visitor/ImportAnalyzer.java#L156

`if` statement has empty body

Statement with empty body: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/LambdaToExecutableReference.java#L49

`if` statement has empty body

Statement with empty body: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L300

`if` statement has empty body

Field can be local: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L38

Field can be converted to a local variable

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/TransformationEngine.java#L37

Field `processors` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java#L17

Field `property` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java#L48

Field `resultFolder` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethodAnalyzer.java#L17

Field `filter` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Change.java#L14

Field `issue` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L18

Field `projectUrl` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/SpoonRefactor.java#L18

Field `ruleParser` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/PositionScanner.java#L20

Field `endLine` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java#L49

Field `qodanaImageName` may be 'final'

Field may be 'final': commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/RemoteProject.java#L13

Field `commits` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L98

Field `ruleParser` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L10

Field `text` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/ProtectedMemberInFinalClass.java#L23

Field `badSmell` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L11

Field `markdownText` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L97

Field `listener` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L16

Field `snippet` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/ChangeListener.java#L14

Field `changelog` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L13

Field `filePath` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/PositionScanner.java#L18

Field `startLine` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/impl/MongoProjectConfigRepository.java#L15

Field `projectConfigConverter` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Change.java#L15

Field `affectedType` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java#L51

Field `sourceFileRoot` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/ChangeListener.java#L13

Field `changedTypes` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L37

Field `settings` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L19

Field `commitHash` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L15

Field `messageMarkdown` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/formatting/ImportGrouper.java#L12

Field `style` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L20

Field `position` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L36

Field `refactorings` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/SpoonRefactor.java#L19

Field `refactors` may be 'final'

Field may be 'final': commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/RemoteProject.java#L11

Field `projectUrl` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/equals_hashcode/EqualsHashcode.java#L13

Field `affectedType` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/ToArrayCallWithZeroLengthArrayArgument.java#L19

Field `badSmell` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L12

Field `ruleID` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L15

Field `affectedType` may be 'final'

Field may be 'final': commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/RemoteProject.java#L10

Field `projectName` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L35

Field `ruleParser` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/Index_off_replaceable_by_contains/IndexOfReplaceableByContainsAnalyzer.java#L23

Field `matcher` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L11

Field `identifier` may be 'final'

Field may be 'final': commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/RemoteProject.java#L12

Field `commitHashes` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/ImportHelper.java#L86

Field `importString` may be 'final'

Field may be 'final': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L16

Field `affectedMethod` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L151

Field `typeRefQNames` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L14

Field `message` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L99

Field `settings` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L17

Field `projectName` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L148

Field `compilationUnit` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/BadSmell.java#L10

Field `analyzer` may be 'final'

Field may be 'final': github-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/impl/MongoProjectRepository.java#L17

Field `projectDaoConverter` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Link.java#L5

Field `url` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/printing/ChangedTypePrinting.java#L11

Field `prettyPrinter` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L149

Field `computedImports` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/PositionScanner.java#L21

Field `endColumn` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java#L50

Field `resultPathString` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Change.java#L13

Field `text` may be 'final'

Field may be 'final': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Changelog.java#L8

Field `changes` may be 'final'

Result of method call ignored: github-bot/src/main/java/io/github/martinwitt/laughing_train/mining/SpoonPeriodicMiner.java#L74

Result of `File.delete()` is ignored

Inner class may be 'static': spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/access_static_via_instance/AccessStaticViaInstanceAnalyzer.java#L29

Inner class `StaticInvocationFilter` may be 'static'

Javadoc declaration problems: commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/GitHubCommit.java#L17

`@param analyzerStatuses` tag description is missing

Javadoc declaration problems: github-bot/src/main/java/io/github/martinwitt/laughing_train/mining/SearchProjectService.java#L47

`@throws` tag description is missing

Javadoc declaration problems: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L19

`@param affectedType` tag description is missing

Javadoc declaration problems: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethod.java#L20

`@param affectedMethod` tag description is missing

Javadoc declaration problems: commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/GitHubCommit.java#L16

`@param commitHash` tag description is missing

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java#L30

Cannot resolve symbol `run`

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java#L61

Cannot resolve symbol `ImportConflictDetector`

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L5

Cannot resolve symbol `asMarkdown`

Declaration has problems in Javadoc references: application/src/main/java/io/github/martinwitt/laughing_train/application/base/converter/Converter.java#L19

Cannot resolve symbol `source`

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/MarkdownString.java#L5

Cannot resolve symbol `asString`

Declaration has problems in Javadoc references: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/util/Nullsafe.java#L32

Cannot resolve symbol

Use of Optional.ofNullable with null or not-null argument: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/AnalyzerResultVisitor.java#L78

'Optional.ofNullable()' with non-null argument should be replaced with 'Optional.of()'

Use of Optional.ofNullable with null or not-null argument: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/AnalyzerResultVisitor.java#L225

'Optional.ofNullable()' with non-null argument should be replaced with 'Optional.of()'

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/InstantReturn.java#L40

Casting `element.getBody().getLastStatement()` to `CtReturn` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/BooleanExpression.java#L31

Casting `element.getLeftHandOperand()` to `CtExpression` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L22

Casting `getFactory().Type().createReference(...)` to `CtTypeReference` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/migration/ExpectedExceptionRemoval.java#L110

Casting `getFactory().Type().voidType()` to `CtTypeReference` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L37

Casting `new NewLineAnnotation<>()` to `NewLineAnnotation` is redundant

Redundant type cast: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/InstantReturn.java#L50

Casting `thenBlock.getStatement(...)` to `CtReturn` is redundant

Redundant 'File' instance creation: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java#L23

`new File` is redundant

Labeled switch rule has redundant code block: github-bot/src/main/java/io/github/martinwitt/laughing_train/mining/SpoonPeriodicMiner.java#L80

Labeled rule's code block is redundant

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseSameCheck.java#L86

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseEqualsCheck.java#L86

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueSameCheck.java#L86

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueEqualsCheck.java#L85

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNotNullTransformation.java#L103

Redundant call to `format()`

Redundant call to 'String.format()': code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNullTransformation.java#L103

Redundant call to `format()`

Stream API call chain can be simplified: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/CollectionEmptyCheck.java#L62

'collect(toList())' can be replaced with 'toList()'

Stream API call chain can be simplified: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/ProtectedMemberInFinalType.java#L42

'collect(toList())' can be replaced with 'toList()'

String concatenation as argument to 'StringBuilder.append()' call: github-bot/src/main/java/io/github/martinwitt/laughing_train/ChangelogPrinter.java#L33

String concatenation as argument to `StringBuilder.append()` call

String concatenation as argument to 'StringBuilder.append()' call: github-bot/src/main/java/io/github/martinwitt/laughing_train/ChangelogPrinter.java#L70

String concatenation as argument to `StringBuilder.append()` call

String concatenation as argument to 'StringBuilder.append()' call: github-bot/src/main/java/io/github/martinwitt/laughing_train/ChangelogPrinter.java#L59

String concatenation as argument to `StringBuilder.append()` call

String concatenation as argument to 'StringBuilder.append()' call: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Changelog.java#L30

String concatenation as argument to `StringBuilder.append()` call

Minimum 'switch' branches: github-bot/src/main/java/io/github/martinwitt/laughing_train/services/SpoonAnalyzerService.java#L31

'switch' statement has too few case labels (1), and should probably be replaced with an 'if' statement

Call to 'printStackTrace()': github-bot/src/main/java/io/github/martinwitt/laughing_train/Config.java#L116

Call to `printStackTrace()` should probably be replaced with more robust logging

Redundant 'if' statement: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/EmptyStringCheck.java#L50

`if` statement can be simplified

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/UnnecessaryLocalVariable.java#L57

Unchecked assignment: 'spoon.reflect.code.CtExpression' to 'spoon.reflect.code.CtExpression'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/UnnecessaryStringEscape.java#L70

Unchecked cast: 'spoon.reflect.declaration.CtElement' to 'spoon.reflect.code.CtLiteral'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L22

Unchecked assignment: 'spoon.reflect.reference.CtTypeReference' to 'spoon.reflect.reference.CtTypeReference'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/ThreadLocalWithInitial.java#L124

Unchecked cast: 'spoon.reflect.code.CtStatement' to 'spoon.reflect.code.CtReturn'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/InstantReturn.java#L32

Unchecked assignment: 'spoon.reflect.code.CtExpression' to 'spoon.reflect.code.CtExpression'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/NewLineAnnotation.java#L37

Unchecked cast: 'xyz.keksdose.spoon.code_solver.spoon.NewLineAnnotation' to 'xyz.keksdose.spoon.code_solver.spoon.NewLineAnnotation'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/CodeBlock2Expr.java#L62

Unchecked call to 'setExpression(CtExpression)' as a member of raw type 'spoon.reflect.code.CtLambda'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/UnnecessaryToStringCall.java#L73

Unchecked cast: 'spoon.reflect.declaration.CtElement' to 'spoon.reflect.code.CtInvocation'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/BooleanExpression.java#L31

Unchecked cast: 'spoon.reflect.code.CtExpression\>' to 'spoon.reflect.code.CtExpression'

Unchecked warning: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/size_replaceable_by_is_empty/SizeReplaceableByIsEmptyAnalyzer.java#L52

Unchecked assignment: 'java.util.Optional' to 'java.util.Optional\>'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/UtilityClassWithoutPrivateConstructor.java#L112

Unchecked assignment: 'spoon.reflect.declaration.CtConstructor' to 'spoon.reflect.declaration.CtConstructor'

Unchecked warning: spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/size_replaceable_by_is_empty/SizeReplaceableByIsEmptyAnalyzer.java#L87

Unchecked call to 'setOperand(CtExpression)' as a member of raw type 'spoon.reflect.code.CtUnaryOperator'

Unchecked warning: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/LambdaToExecutableReference.java#L63

Unchecked assignment: 'spoon.reflect.reference.CtExecutableReference' to 'spoon.reflect.reference.CtExecutableReference'

Redundant local variable: code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNullTransformation.java#L30