Get the mod building in both debug and release mode #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add documentation for getting this building locally.
nickdavies
reviewed
Jan 26, 2024
| @@ -23,6 +23,17 @@ This mod works with a single dll file but we also provide a way to downpatch the | |||
| installing the latest Microsoft Visual C++ Redistributable version could fix it : https://aka.ms/vs/17/release/vc_redist.x64.exe. | |||
| - The Windows console tends to freeze preventing you from sending or receiving any items. You must Alt+Tab, click on the console and press enter to refresh it. | |||
|
|
|||
| ## Building Locally | |||
|
|
|||
| 1. Clone the repository (`git clone https://github.com/Marechal-L/Dark-Souls-III-Archipelago-clieng.git`). | |||
There was a problem hiding this comment.
Thanks for writing these! They helped me get building. Perhaps you have submodule.recurse and I don't cause I also had to do the git submodule commands to pull down those before it would build.
nickdavies
reviewed
Jan 27, 2024
|
|
||
| 1. Clone the repository (`git clone https://github.com/Marechal-L/Dark-Souls-III-Archipelago-clieng.git`). | ||
| 2. Open `archipelago-client\archipelago-client.sln` in Visual Studio. | ||
| 3. [Install OpenSSL for Windows](https://slproweb.com/products/Win32OpenSSL.html). |
There was a problem hiding this comment.
it took me a little while to figure out that you need SSL version 1.1 for this to work (at least that's what I needed on my PC). I am not sure if that's just something about my setup or if it's true for everyone though. If you happen to know I think it would be useful to include that in this instruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add documentation for getting this building locally.