Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#297 cannot invoke bucket4 j boot properties.get methods() because bucket4j properties is null #303

Merged
merged 2 commits into from
May 30, 2024
Merged

Feature/#297 cannot invoke bucket4 j boot properties.get methods() because bucket4j properties is null #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb2448
Cannot invoke Bucket4JBootProperties.getMethods()" because "bucket4jP…
MarcGiffing May 30, 2024
b077c37
Cannot invoke Bucket4JBootProperties.getMethods()" because "bucket4jP…
MarcGiffing May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...iffing/bucket4j/spring/boot/starter/config/condition/OnAsynchronousPropertyCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ public class OnAsynchronousPropertyCondition extends SpringBootCondition {
@Override
public ConditionOutcome getMatchOutcome(ConditionContext context, AnnotatedTypeMetadata metadata) {
var bucket4jProperties = Binder.get(context.getEnvironment()).bind("bucket4j", Bucket4JBootProperties.class).orElse(null);
if (bucket4jProperties == null) {
return ConditionOutcome.noMatch("@ConditionalOnAsynchronousPropertyCondition Bucket4jBootProperties not configured");
}
var reactiveFilterConfigurationExists = bucket4jProperties.getFilters()
.stream()
.anyMatch(x -> List.of(FilterMethod.WEBFLUX, FilterMethod.GATEWAY).contains(x.getFilterMethod()));
Expand Down
3 changes: 3 additions & 0 deletions ...giffing/bucket4j/spring/boot/starter/config/condition/OnSynchronousPropertyCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ public class OnSynchronousPropertyCondition extends SpringBootCondition {
@Override
public ConditionOutcome getMatchOutcome(ConditionContext context, AnnotatedTypeMetadata metadata) {
var bucket4jProperties = Binder.get(context.getEnvironment()).bind("bucket4j", Bucket4JBootProperties.class).orElse(null);
if (bucket4jProperties == null) {
return ConditionOutcome.noMatch("@ConditionalOnSynchronPropertyCondition Bucket4jBootProperties not configured");
}
var methodConfigurationExists = !bucket4jProperties.getMethods().isEmpty();
var servletConfigurationExist = bucket4jProperties.getFilters().stream().anyMatch(x -> x.getFilterMethod().equals(FilterMethod.SERVLET));
if (methodConfigurationExists || servletConfigurationExist) {
Expand Down
Loading