Resolve bug mentioned in Issue #222 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #222 mentioned a nullpointer exception when starting the application. After investigating I discovered that this issue came from an unwanted 'matchIfMissing = true' on CacheListener and CacheManager bean instantiation conditions, which I overlooked during local testing.
This pull request removes the unwanted matchIfMissing, and also includes an update of the example testclasses and properties files to make it easier to test it.
Can be tested by removing the 'filter-config-caching-enabled' property from the application.yml and 'filterConfigCache' cache from the cache configuration in an example project and trying to run it. This should now work without problems.