Feature/#297 cannot invoke bucket4 j boot properties.get methods() be…

…cause bucket4j properties is null (#303) * Cannot invoke Bucket4JBootProperties.getMethods()" because "bucket4jProperties" is null #297 * Cannot invoke Bucket4JBootProperties.getMethods()" because "bucket4jProperties" is null #297
MarcGiffing · May 30, 2024 · c2b80ea · c2b80ea
1 parent 7a6d731
commit c2b80ea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...iffing/bucket4j/spring/boot/starter/config/condition/OnAsynchronousPropertyCondition.java b/...iffing/bucket4j/spring/boot/starter/config/condition/OnAsynchronousPropertyCondition.java
@@ -14,6 +14,9 @@ public class OnAsynchronousPropertyCondition extends SpringBootCondition {
     @Override
     public ConditionOutcome getMatchOutcome(ConditionContext context, AnnotatedTypeMetadata metadata) {
         var bucket4jProperties = Binder.get(context.getEnvironment()).bind("bucket4j", Bucket4JBootProperties.class).orElse(null);
+        if (bucket4jProperties == null) {
+            return ConditionOutcome.noMatch("@ConditionalOnAsynchronousPropertyCondition Bucket4jBootProperties not configured");
+        }
         var reactiveFilterConfigurationExists = bucket4jProperties.getFilters()
                 .stream()
                 .anyMatch(x -> List.of(FilterMethod.WEBFLUX, FilterMethod.GATEWAY).contains(x.getFilterMethod()));

diff --git a/...giffing/bucket4j/spring/boot/starter/config/condition/OnSynchronousPropertyCondition.java b/...giffing/bucket4j/spring/boot/starter/config/condition/OnSynchronousPropertyCondition.java
@@ -12,6 +12,9 @@ public class OnSynchronousPropertyCondition extends SpringBootCondition {
     @Override
     public ConditionOutcome getMatchOutcome(ConditionContext context, AnnotatedTypeMetadata metadata) {
         var bucket4jProperties = Binder.get(context.getEnvironment()).bind("bucket4j", Bucket4JBootProperties.class).orElse(null);
+        if (bucket4jProperties == null) {
+            return ConditionOutcome.noMatch("@ConditionalOnSynchronPropertyCondition Bucket4jBootProperties not configured");
+        }
         var methodConfigurationExists = !bucket4jProperties.getMethods().isEmpty();
         var servletConfigurationExist = bucket4jProperties.getFilters().stream().anyMatch(x -> x.getFilterMethod().equals(FilterMethod.SERVLET));
         if (methodConfigurationExists || servletConfigurationExist) {