Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role and aria-label to attribution control. #598

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Add role and aria-label to attribution control. #598

merged 1 commit into from
Nov 25, 2021

Conversation

prushforth
Copy link
Member

Addresses one task in #247

@prushforth prushforth requested a review from Malvoz November 24, 2021 22:44
@Malvoz Malvoz mentioned this pull request Nov 24, 2021
Open
43 tasks
Malvoz
Malvoz approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@Malvoz Malvoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested in NVDA and it's definitely an improvement. Thanks!

@prushforth prushforth merged commit 71fceb2 into Maps4HTML:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malvoz Malvoz Malvoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prushforth @Malvoz