Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role='application' to FeatureGroup <g> element #466

Closed
wants to merge 1 commit into from

Conversation

prushforth
Copy link
Member

Fixes #423

@prushforth prushforth requested a review from Malvoz May 18, 2021 01:46
@Malvoz
Copy link
Member

Malvoz commented May 18, 2021

It seems that NVDA announces everything on the page after pressing a feature to open a popup. At this point, I'm starting to think we're doing the user a disservice by not just making the entire map role="application".

@prushforth
Copy link
Member Author

Ok I'll have a look at that when I get a chance.

@Malvoz
Copy link
Member

Malvoz commented May 18, 2021

Maybe we should just go ahead and replace role="region" of the maps (in web-map.js as well) with role="application" (and close out #274).

I'll go ahead and do some testing with that approach, see how it behaves.

@prushforth
Copy link
Member Author

For some reason I didn't experience NVDA reading the whole page. I only tried it on the restaurant page though.

@Malvoz Malvoz mentioned this pull request May 18, 2021
@prushforth prushforth deleted the misplaced-popups branch April 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popups are misplaced when using a screen reader
2 participants